Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cypress MapLibreMap test Should remove and re-add the MapLibreMap… #199

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cioddi
Copy link
Member

@cioddi cioddi commented Feb 14, 2025

… component and verify initialization

Initial intent of this PR was to add a test that reproduces the error that occurs in this (https://github.com/bcgov/WetpaddlersV2/tree/main/app) app when switching back and forth from "Map" and "DatasetList". when going back to map from Datasetlist the app crashes.

Simply toggling the MapLibreMap Component in and out of React-DOM, as done in the cypress test that was added in this PR, appears to not reproduce the error.

Todos:

  • - create a test case that reproduces the error in the wetpaddlers app or identify the cause outside of @mapcomponents/react-maplibre
  • - adjust the MapLibreMap component to make the test pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant