Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace reviung39 with reviung41_39 #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jablko
Copy link

@jablko jablko commented Oct 25, 2023

The REVIUNG39 outboard is slightly behind the REVIUNG41 (it's missing nice_nano_v2.overlay and MIRYOKU_LAYERS_FLIP), this change syncs them up.

The REVIUNG39 and 41 are almost the same --- you could flash both with the same firmware: reviewing the three ZMK REVIUNG39 PRs (zmkfirmware/zmk#622, zmkfirmware/zmk#695, and zmkfirmware/zmk#795), plus the REVIUNG39 vs. 41 QMK keyboards and the REVIUNG39 vs. 41 KiCad files, the only difference is that keymap positions RC(6,0), RC(6,1), and RC(6,2) vs. RC(6,1), RC(6,2), and RC(6,3) are mapped to SPC, ENT, and BSPC. Otherwise they're identical --- they share a common default keymap except for the outer thumbs.

So I added a reviung41_39 variant instead of duplicating boards/shields/reviung41 and used a matrix transform to account for the only difference. I repeated the RC(6,0) entry: map = <... RC(6,0) RC(6,0) RC(6,1) RC(6,2)>;, which expands to static uint32_t transform[] = {... [36] = 36, [36] = 37, [37] = 38, [38] = 39}; and transforms both boards' thumbs to the same keymap positions.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outboards are now documented at https://github.com/manna-harbour/miryoku_zmk#outboards. The zmk option has been replaced by https://github.com/manna-harbour/miryoku_zmk#outboard_branches. However, that should be used only where a keyboard requires additional code in a ZMK fork to operate. If the keyboard definition only is contained in a ZMK fork, https://github.com/manna-harbour/miryoku_zmk#repository-and-symlink-variables or https://github.com/manna-harbour/miryoku_zmk#outboard_modules should be used instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants