Fix delayed spacebar in TAP layer when using thumbcombos #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by turning off combos when entering tap layer
|
What about this PR? I am still using it on my board an it still makes sense to me |
Comment on lines
+92
to
+100
| layer_state_t default_layer_state_set_user(layer_state_t state) { | ||
| if (get_highest_layer(state) == U_TAP) { | ||
| combo_disable(); | ||
| } else { | ||
| combo_enable(); | ||
| } | ||
|
|
||
| return state; | ||
| } |
There was a problem hiding this comment.
U_TAP may not be defined if manna-harbour/miryoku#85 is used to remove or rename the layer.
Wrapping with #if defined (U_TAP) / #endif should deal with that.
|
I agree, that should be the default behaviour. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by turning off combos when entering tap layer.
I had this issue where using space in games always felt so delayed on my 34-key Ferris Sweep even though I was using the tap layer and I managed to track it down to the combo handling.
So I added this code to automatically disable and enable combos when entering/leaving the tap layer.
I think this could be useful default behaviour. What do you think?