Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create get-domain-admins.yml #1012

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kevross33
Copy link

Create signature for samples executing net group "domain admins" /domain i..e SHA256 47e9917ce0afc96632db5e95db2fd9aff10d05b0399fd05d02035eacb3c1f399

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Create signature for samples executing net group "domain admins" /domain i..e SHA256 47e9917ce0afc96632db5e95db2fd9aff10d05b0399fd05d02035eacb3c1f399
Copy link

google-cla bot commented Mar 5, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@mike-hunhoff mike-hunhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, I've left comments for your review

Comment on lines +15 to +19
- and:
- string: /net/i
- string: /group/i
- string: /domain admins/i
- string: //domain/i
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little broad - is there anything else we could add to reduce the risk of FPs (e.g. api, match features)?

att&ck:
- Discovery::Permission Groups Discovery [T1069]
examples:
- f5fca1b178af87bd48c7ea9e3f2c957b
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the address where this rule is matched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants