Fix s3 https connection on windows #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoebusm
force-pushed
the
fix/s3_windows_https_conn
branch
from
3cfda12 to
bad019d
Compare
phoebusm
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
poodlewars
approved these changes
Feb 17, 2025
poodlewars
reviewed
Feb 17, 2025
cpp/vcpkg.json
Outdated
| @@ -109,7 +109,7 @@ | |||
| "overrides": [ | |||
| { "name": "openssl", "version-string": "3.3.0" }, | |||
| { "name": "arrow", "version": "18.0.0" }, | |||
| { "name": "aws-sdk-cpp", "version": "1.11.474" }, | |||
| { "name": "aws-sdk-cpp", "version": "1.11.474", "$note": "Update overlay json to upgrade" }, | |||
There was a problem hiding this comment.
Can you put a note here warning people not to upgrade to 1.11.486+ yet?
|
Real S3 https test: https://github.com/man-group/ArcticDB/actions/runs/13339440327 |
|
Upstream change for conda: aws/aws-sdk-cpp#3304 |
G-D-Petrov
approved these changes
Feb 18, 2025
Pass |
phoebusm
added a commit
that referenced
this pull request
Feb 18, 2025
#### Reference Issues/PRs <!--Example: Fixes #1234. See also #3456.--> https://man312219.monday.com/boards/7852509418/pulses/8485223765 #### What does this implement or fix? 1. Change s3 persistence test endpoint to `https` 2. Patch aws sdk on pypi build as temporary fix for aws/aws-sdk-cpp#3008 3. Upgrade aws sdk to the version specified in `vcpkg.json` For conda, patch will be submitted upstream ## Change Type (Required) - [x] **Patch** (Bug fix or non-breaking improvement) - [ ] **Minor** (New feature, but backward compatible) - [ ] **Major** (Breaking changes) - [ ] **Cherry pick** #### Any other comments? #### Checklist <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details> <!-- Thanks for contributing a Pull Request to ArcticDB! Please ensure you have taken a look at: - ArcticDB's Code of Conduct: https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md - ArcticDB's Contribution Licensing: https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing -->
This was referenced Feb 18, 2025
Closed
phoebusm
added a commit
that referenced
this pull request
Feb 18, 2025
…elease branch (#2187) #### Reference Issues/PRs <!--Example: Fixes #1234. See also #3456.--> Cherrypicking #2182 to v5.2.4 release branch #### What does this implement or fix? 1. Change s3 persistence test endpoint to `https` 2. Patch aws sdk on pypi build as temporary fix for aws/aws-sdk-cpp#3008 3. Upgrade aws sdk to the version specified in `vcpkg.json` For conda, patch will be submitted upstream ## Change Type (Required) - [x] **Patch** (Bug fix or non-breaking improvement) - [ ] **Minor** (New feature, but backward compatible) - [ ] **Major** (Breaking changes) - [ ] **Cherry pick** #### Any other comments? #### Checklist <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details> <!-- Thanks for contributing a Pull Request to ArcticDB! Please ensure you have taken a look at: - ArcticDB's Code of Conduct: https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md - ArcticDB's Contribution Licensing: https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing -->
jamesmunro
pushed a commit
that referenced
this pull request
Feb 25, 2025
#### Reference Issues/PRs <!--Example: Fixes #1234. See also #3456.--> https://man312219.monday.com/boards/7852509418/pulses/8485223765 #### What does this implement or fix? 1. Change s3 persistence test endpoint to `https` 2. Patch aws sdk on pypi build as temporary fix for aws/aws-sdk-cpp#3008 3. Upgrade aws sdk to the version specified in `vcpkg.json` For conda, patch will be submitted upstream ## Change Type (Required) - [x] **Patch** (Bug fix or non-breaking improvement) - [ ] **Minor** (New feature, but backward compatible) - [ ] **Major** (Breaking changes) - [ ] **Cherry pick** #### Any other comments? #### Checklist <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details> <!-- Thanks for contributing a Pull Request to ArcticDB! Please ensure you have taken a look at: - ArcticDB's Code of Conduct: https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md - ArcticDB's Contribution Licensing: https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
https://man312219.monday.com/boards/7852509418/pulses/8485223765
What does this implement or fix?
httpsvcpkg.jsonFor conda, patch will be submitted upstream
Change Type (Required)
Any other comments?
Checklist
Checklist for code changes...