Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Graphql] applied_to must exist on an orderItem #39772

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

indykoning
Copy link

@indykoning indykoning commented Mar 27, 2025

Description (*)

Due to

applied_to: CartDiscountType! @doc(description:"The type of the entity the discount is applied to.")
discount being used in order_item applied_to MUST be present if a discount is present.

Because this is missing errors will be thrown once the applied_to is missing. There are 2 ways to fix this. Remove the not null requirement on applied_to or adding the applied_to on the order item as well.
I believe adding it to the order item could result in more consistent frontend as we keep the data between cart item and order item te same.

Manual testing scenarios (*)

Create/fetch an order using Graphql that has orderitems with discounts, make sure to get the discounts and applied_to (as defined by the graphql schema).
You will see the following error
image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] [Graphql] applied_to must exist on an orderItem #39782: [Graphql] applied_to must exist on an orderItem

Copy link

m2-assistant bot commented Mar 27, 2025

Hi @indykoning. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Hotel
Copy link
Contributor

@magento create issue

@engcom-Hotel engcom-Hotel added Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] [Graphql] applied_to must exist on an orderItem
2 participants