Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-39692 Widget Block Selection issue fix - If block have same identifier #39722

Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/code/Magento/Cms/Block/Adminhtml/Block/Widget/Chooser.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2011 Adobe
* All Rights Reserved.
*/
namespace Magento\Cms\Block\Adminhtml\Block\Widget;

Expand Down Expand Up @@ -100,7 +100,7 @@ public function getRowClickCallback()
$js = '
function (grid, event) {
var trElement = Event.findElement(event, "tr");
var blockId = trElement.down("td").next().next().innerHTML.replace(/^\s+|\s+$/g,"");
var blockId = trElement.down("td").innerHTML.replace(/^\s+|\s+$/g,"");
var blockTitle = trElement.down("td").next().innerHTML;
' .
$chooserJsObject .
Expand Down
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2011 Adobe
* All Rights Reserved.
*/
declare(strict_types=1);

namespace Magento\Cms\Test\Unit\Block\Adminhtml\Block\Widget;

use Magento\Backend\Block\Template\Context;
use Magento\Backend\Helper\Data;
use Magento\Cms\Block\Adminhtml\Block\Widget\Chooser;
use Magento\Cms\Model\Block;
use Magento\Cms\Model\BlockFactory;
use Magento\Cms\Model\ResourceModel\Block\CollectionFactory;
use Magento\Framework\Data\Form\Element\AbstractElement;
use Magento\Framework\Escaper;
use Magento\Framework\Math\Random;
Expand Down Expand Up @@ -77,6 +79,16 @@ class ChooserTest extends TestCase
*/
protected $chooserMock;

/**
* @var Data|MockObject
*/
protected $backendHelperMock;

/**
* @var CollectionFactory|MockObject
*/
protected $collectionFactoryMock;

protected function setUp(): void
{
$this->layoutMock = $this->getMockBuilder(LayoutInterface::class)
Expand All @@ -93,6 +105,7 @@ protected function setUp(): void
->onlyMethods(
[
'escapeHtml',
'escapeJs'
]
)
->getMock();
Expand Down Expand Up @@ -138,6 +151,13 @@ protected function setUp(): void
)
->onlyMethods(['toHtml'])
->getMockForAbstractClass();
$this->backendHelperMock = $this->getMockBuilder(Data::class)
->disableOriginalConstructor()
->getMock();

$this->collectionFactoryMock = $this->getMockBuilder(CollectionFactory::class)
->disableOriginalConstructor()
->getMock();

$objectManager = new ObjectManager($this);
$objectManager->prepareObjectManager();
Expand Down Expand Up @@ -286,4 +306,33 @@ public function testGetGridUrl()

$this->assertEquals($url, $this->this->getGridUrl());
}

/**
* @covers \Magento\Cms\Block\Adminhtml\Block\Widget\Chooser::testGetRowClickCallback
*/
public function testGetRowClickCallback(): void
{
$chooserBlock = new Chooser(
$this->context,
$this->backendHelperMock,
$this->blockFactoryMock,
$this->collectionFactoryMock
);
$this->escaper->expects($this->once())
->method('escapeJs')
->willReturnCallback(function ($input) {
return $input;
});
$jsCallback = $chooserBlock->getRowClickCallback();

$this->assertStringContainsString(
'blockId = trElement.down("td").innerHTML.replace(/^\s+|\s+$/g,"")',
$jsCallback,
'JavaScript callback should use first TD cell for block ID'
);

$this->assertStringContainsString('setElementValue(blockId)', $jsCallback);
$this->assertStringContainsString('setElementLabel(blockTitle)', $jsCallback);
$this->assertStringContainsString('close()', $jsCallback);
}
}