[hw] Enable build and test for Python 3.11 and 3.12 #5393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csharplus
changed the title
csharplus
force-pushed
the
csharplus_enable_python_3.12
branch
3 times, most recently
from
a00344d
to
2cdb7ac
Compare
setup.py
Outdated
| @@ -117,9 +122,12 @@ def readme(): | |||
| 'confluent-avro~=1.8.0', | |||
| 'elasticsearch==8.9.0', | |||
| 'influxdb_client==1.36.1', | |||
| 'kafka-python==2.0.2', | |||
| "kafka-python==2.0.2; python_version < '3.12'", | |||
| "kafka-python @ git+https://github.com/dpkp/kafka-python.git ; " | |||
There was a problem hiding this comment.
we can't use library from github repo in pypi package
There was a problem hiding this comment.
It is an issue of kafka-python tracked at dpkp/kafka-python#2412, without a good solution so far.
There was a problem hiding this comment.
Found another work-around about this issue, given in https://stackoverflow.com/questions/77287622/modulenotfounderror-no-module-named-kafka-vendor-six-moves-in-dockerized-djan
csharplus
force-pushed
the
csharplus_enable_python_3.12
branch
from
260cab3
to
8e7d598
Compare
wangxiaoyou1993
approved these changes
Sep 17, 2024
csharplus
force-pushed
the
csharplus_enable_python_3.12
branch
from
60c0a08
to
493c599
Compare
csharplus
force-pushed
the
csharplus_enable_python_3.12
branch
from
5babe7c
to
9e62fd3
Compare
This was referenced Sep 22, 2024
Closed
csharplus
changed the title
This was referenced Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The builds and tests for Python 3.11 and 3.12 were skipped so far for Mage, which have been enabled.
How Has This Been Tested?
Checklist
cc:
@wangxiaoyou1993