Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Buffer with Uint8Array #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gozala
Copy link

@Gozala Gozala commented Jun 8, 2020

Fixes #52

Had to upgrade standard because older version complained about use of TextDecoder.

It is worth pointing out that TextDecoder / TextEncoder had being added in node 11 as far as I can tell. If that is a concern I can update code to import those from utils.

@Gozala
Copy link
Author

Gozala commented Jun 9, 2020

Strange, I wonder why CI is has not picked this up.

@mafintosh
Copy link
Owner

Is this critical for you? Otherwise I’d prefer to wait until 10 goes EOL, to avoid too massive breakage.

@mafintosh
Copy link
Owner

My guess would be that util adds much more overhead than Buffer

@Gozala
Copy link
Author

Gozala commented Jun 9, 2020

Is this critical for you? Otherwise I’d prefer to wait until 10 goes EOL, to avoid too massive breakage.

No rush, I have plenty of other places I need to prune of node Buffers, so this can wait until 10 goes EOL.

My guess would be that util adds much more overhead than Buffer

That is also why I was hesitent to do that.

Part of me also just wishes this lib was just taking string and did not concern itself with buf.toString() but that probably is too big of a change to be worth it.

@jimmywarting
Copy link

I’d prefer to wait until 10 goes EOL, to avoid too massive breakage.

Guess it's time now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Buffer dependency and use Uint8Array
3 participants