Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handling A additionals and out-of-order results, so that the correct IP address can be parsed #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

handling A additionals and out-of-order results, so that the correct IP address can be parsed #33

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ab429c
handling A additionals, so that the correct IP address can be parsed
catdad Jun 1, 2018
2371ff8
handling race condition between multicast-dns and node-ssdp and clean…
catdad Jun 12, 2018
b237482
use only TXT records for determining a device name
catdad Jun 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 23 additions & 24 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,20 @@ var toSubtitles = function (url, i) {
}
}

var getName = function (records) {
if (records['TXT']) {
var text = txt.decode(records['TXT'].data)
if (text.fn) return text.fn
}
return null
}

var getHost = function (records) {
if (records['A']) return records['A'].data
if (records['SRV']) return records['SRV'].data.target
return null
}

module.exports = function () {
var dns = mdns()
var that = new events.EventEmitter()
Expand Down Expand Up @@ -239,34 +253,19 @@ module.exports = function () {
}

dns.on('response', function (response) {
response.answers.forEach(function (a) {
if (a.type === 'PTR' && a.name === '_googlecast._tcp.local') {
var name = a.data
var shortname = a.data.replace('._googlecast._tcp.local', '')
if (!casts[name]) casts[name] = {name: shortname, host: null}
}
})
var records = response.additionals.concat(response.answers).reduce(function (memo, record) {
memo[record.type] = record
return memo
}, {})

var onanswer = function (a) {
debug('got answer %j', a)
var device = { host: getHost(records), name: getName(records) }

var name = a.name
if (a.type === 'SRV' && casts[name] && !casts[name].host) {
casts[name].host = a.data.target
emit(casts[name])
}
if (!device.name || !device.host) return

if (a.type === 'TXT' && casts[name]) {
var text = txt.decode(a.data)
if (text.fn) {
casts[name].name = text.fn
emit(casts[name])
}
}
if (!casts[device.name]) {
casts[device.name] = device
emit(device)
}

response.additionals.forEach(onanswer)
response.answers.forEach(onanswer)
})

if (ssdp) {
Expand Down