Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for basic glob patterns in "inputFile" #199

Closed
wants to merge 2 commits into from
Closed

Added support for basic glob patterns in "inputFile" #199

wants to merge 2 commits into from

Conversation

mrcrowl
Copy link

@mrcrowl mrcrowl commented Mar 21, 2016

This allows the "inputFile" attribute of each config to include the glob
characters: *?

Any file which matches the glob pattern will be compiled. The
"outputFile" attribute is ignored and instead the sourceFile's path is
used as the output file, but with the extension changed to the compiled
extension. e.g. less --> css

Saving the compilerconfig.json currently does not compile all matching
files in the project.

This allows the "inputFile" attribute of each config to include the glob
characters: *?

Any file which matches the glob pattern will be compiled.  The
"outputFile" attribute is ignored and instead the sourceFile's path is
used as the output file, but with the extension changed to the compiled
extension.  e.g. less --> css

Saving the compilerconfig.json currently does not compile all matching
files in the project.
@mrcrowl mrcrowl mentioned this pull request Mar 21, 2016
Further problem caused by glob patterns.
return ".es5.js";

default:
return ".css";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks a bit tricky.

edit: I see it was already there

@madskristensen
Copy link
Owner

Shouldn't it work like this:

If outputFile is a folder name, compile each file found in inputFile globbing and dump the resulting .css files in that folder. If outputFile is indeed a file name, then concat the entire output into that single file

@mrcrowl
Copy link
Author

mrcrowl commented Mar 23, 2016

I'm unsure. What I read from the comments in issue #49 is that your users
are primarily looking to restore the behaviour that was present in Web
Essentials 2013, where a css file would be generated in the same directory
as the less file lives. This is certainly what I was after.

Perhaps other could comment on their perspective?
On Tue, 22 Mar 2016 at 4:39 AM, Mads Kristensen [email protected]
wrote:

Shouldn't it work like this:

If outputFile is a folder, compile each file found in inputFile globbing
and dump the resulting .css in that folder. If outputFile is indeed a
file name, then concat the entire output into that single file


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#199 (comment)

@longzheng
Copy link

+1 a way to restore Web Essentials 2013 functionality of auto compiling all files in the same directory with the same filename.

@damiangreen
Copy link

yes please +1

@304NotModified
Copy link

+1

@larsendaniel
Copy link

Another +1 vote! This is sorely needed.

@304NotModified
Copy link

304NotModified commented Jun 16, 2017

@madskristensen What should be changed to get this merged/accepted?

@madskristensen
Copy link
Owner

@304NotModified it contains conflicts that prohibits me from merging the PR.

@LordJZ
Copy link

LordJZ commented Jul 3, 2017

Wow, it's surprising to see this very basic regression not being fixed in almost 2 years.

@304NotModified
Copy link

I can rebase this (and create a new PR), could someone test it?

@mrcrowl
Copy link
Author

mrcrowl commented Jul 3, 2017 via email

@304NotModified
Copy link

VS code is nice, but it's a bit pain to use 2 IDEs (VS + VS code), also we need this on the CI server.

@LordJZ
Copy link

LordJZ commented Jul 3, 2017

I am rebasing this right now and will test.

@304NotModified
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants