-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New port py-pyside6, version 6.8.2.1 #27901
base: master
Are you sure you want to change the base?
Conversation
I have no means to debug the MacOS 13 build failure. Can someone figure it out or should I just set the minimum OS to 14 (darwin >= 23)? The error message given during build is not very helpful. @reneeotten, any thoughts? |
Port limited to MacOS >= 14 (darwin >= 23) due to build issues. Ticket reference: https://trac.macports.org/ticket/70343
As there have been no comments, the platform has been limited to darwin >= 23 (MacOS >= 14) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build log indicates potential missing dependency qt6-qtwebengine:
2025-03-20T13:13:54.1834120Z CMake Warning at cmake/PySideHelpers.cmake:134 (find_package):
2025-03-20T13:13:54.1834480Z By not providing "FindQt6WebEngineQuick.cmake" in CMAKE_MODULE_PATH this
2025-03-20T13:13:54.1835010Z project has asked CMake to find a package configuration file provided by
2025-03-20T13:13:54.1835340Z "Qt6WebEngineQuick", but CMake did not find one.
2025-03-20T13:13:54.1835490Z
2025-03-20T13:13:54.1835630Z Could not find a package configuration file provided by "Qt6WebEngineQuick"
2025-03-20T13:13:54.1835910Z with any of the following names:
2025-03-20T13:13:54.1836030Z
2025-03-20T13:13:54.1836090Z Qt6WebEngineQuickConfig.cmake
2025-03-20T13:13:54.1836270Z qt6webenginequick-config.cmake
2025-03-20T13:13:54.1836390Z
2025-03-20T13:13:54.1836550Z Add the installation prefix of "Qt6WebEngineQuick" to CMAKE_PREFIX_PATH or
2025-03-20T13:13:54.1836890Z set "Qt6WebEngineQuick_DIR" to a directory containing one of the above
2025-03-20T13:13:54.1837240Z files. If "Qt6WebEngineQuick" provides a separate development package or
2025-03-20T13:13:54.1837500Z SDK, be sure it has been installed.
2025-03-20T13:13:54.1837680Z Call Stack (most recent call first):
2025-03-20T13:13:54.1837900Z cmake/PySideSetup.cmake:168 (collect_optional_modules)
2025-03-20T13:13:54.1838100Z CMakeLists.txt:12 (include)
Also can you please confirm this port installs pkgconfig .pc
files and .cmake
files? pyside2 port is missing these files and is blocking me from enabling python bindings for one of my ports. See https://trac.macports.org/ticket/65411.
Can you also temporarily comment out the platform restriction so I can see the failure on macOS 13? No guarantee but I might be able to provide some pointers.
I just did a clean install of both py313-pyside6 and py313-pyside6+addons. By clean I mean that I let MP reinstall qt6 as well according to pyside6 requirements. I'm not seeing this warning. |
I didn't find these files in /opt/local/... at the moment. I will try with --skip-cmake removed as well. I'm not a qt6 nor pyside developer, I only use them, so I'm not exactly sure if, where and when these files should be installed. Aren't they configuration files used for installing the libraries themselves and removing them afterwards should be expected? |
Do you have |
The project itself does use some |
As I wrote, I did a clean install and had MP reinstall qt6 based on pyside requirements So no, I did not have qtwebengine installed. qtwebengine is a dependency of qtwebview, which is listed in pyside portfile. |
…platform restriction for testing. Fixed formatting of comments.
Removing the --skip-cmake argument from destroot only causes more warnings. It has no effect on the requested .pc and .cmake files. I removed the platform version restriction for now so you can have a look at the error. |
I took a look at the log for macOS 13 - newest Qt version supporting that is 6.7, which the newest version of pyside6 might not support anymore. If you do not want to dig in and try to fix this, you could use
This is a type mismatch error and implicit conversion isn't allowed in Qt 6.7. You could try patching the code and change it to
|
Let's ignore this for now.
That dependency is in a nondefault variant so it isn't installed. It's better to just drop the addon variant and always install those dependencies, which is what pyside2 port do. |
The base installation only requires qttools. qtwebengine is one of the extra modules provided by the "addons" variant. So it should not have anything to do with the base installation. What install command are you using or what order are you installing things in or ...? Do you maybe have the qt6 installation in some kind of an incompatible state before installing pyside6? With a clean installation (all qt6 related stuff removed) I am not able to get the warning that you describe. I'm not keen on removing the variant as I don't like bloating installations where a user may not need the extra components. |
Change version fallback to be based on Qt version
Github check will just install the port from a clean enviroment with only default variants. You can check the log of the last build here. By not providing those dependencies by default a lot of the features are disabled:
If you have to keep the installation minimal by default and keep this variant, you would have to add a bunch of args to disable all these optional features to prevent opportunistic use of those packages, in the case of they're already installed as dependencies as some other ports. Then in the variant you'll need to turn all the features back on again. Also I added a commit to fix the fetch error on macOS 13 and changed version fallback to be based on qt version, reason being that Qt 6.8 might be patched to build on macOS 13 in the future, and if that happens you will not need to change this port. |
Ticket reference: https://trac.macports.org/ticket/70343
Description
Type(s)
Tested on
macOS 15.3.2 24D81 arm64
Xcode 16.2 16C5032a
Verification
Have you
port lint
?sudo port test
?sudo port -vst install
? # -s and -t don't work with some core python ports