Made a more effecient and accurate version of drop_slivers for clip #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lwasser this is failing the same tests that it was last time (those three ones in |
lwasser
reviewed
Dec 2, 2019
| # Assert returned data is a geometry collection given sliver geoms | ||
| assert "Polygon" in clip.geom_type[0] | ||
| # Assert returned data is a not geometry collection | ||
| assert (clip.geom_type == "Polygon").any() |
There was a problem hiding this comment.
ok awesome. i didn't think [0] was the way to go... .any() should do the trick!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in changes suggested by joris and updated tests to reflect how the new output works.