Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provided popup delay for tooltip directive #755

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

hbugdoll
Copy link
Member

@hbugdoll hbugdoll commented Feb 15, 2024

What are you changing/introducing

  • Added attribute tooltip-popup-delay to tooltip directive (like in Bootstrap or AngularUI)
    • use of $timeout
    • cancel timeout on mouseleave or when tooltip is destroyed, so it don't get into conflict with other tooltips
  • Example: <span tooltip tooltip-text="Tooltip" tooltip-popup-delay="500">...</span>

What is the reason for changing/introducing

  • Ability to show tooltips with a delay, not only instantly

QA

Q A
Is bugfix? no
New feature? yes
Breaks BC? no
Tests pass? yes
Fixed issues

@nadar
Copy link
Contributor

nadar commented Feb 16, 2024

LGTM

@nadar nadar merged commit 9ee4c9c into luyadev:master Feb 16, 2024
7 of 8 checks passed
@hbugdoll
Copy link
Member Author

Thanks for merging @nadar

@hbugdoll hbugdoll deleted the tooltip-popup-delay branch February 16, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants