Correct keycode URL in settingtypes.txt/minetest.conf.example #15784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y5nw
requested changes
Feb 14, 2025
There was a problem hiding this comment.
Aside from the comment on minetest.conf.example, I am not sure whether this change makes much sense at the moment, given that the syntax for keybinding settings will be broken soon (#14964 and followups) and the current link works well in the interim (our changes to Irrlicht's Keycodes.h so far seem to be only related to code style).
y5nw
added
Maintenance
MiguelPL4
changed the title
sfan5
reviewed
Feb 14, 2025
MiguelPL4
changed the title
appgurueu
added
One approval ✅ ◻️
and removed
Action / change needed
SmallJoker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update old url: https://github.com/minetest/irrlicht/blob/master/include/Keycodes.h
To new: https://github.com/luanti-org/luanti/blob/master/irr/include/Keycodes.h
This PR is a Ready for Review.