Bump OARS content rating to 1.1 #15773
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in GNOME Software, the age rating have several categories marked as "unknown".
This notably includes categories added in 1.1 (desecration, slavery, etc), but it seems in the case of GNOME Software the nudity category as a whole is also considered unknown when using OARS 1.0.
So I did the following:
Theorically the spec defines that if a property isn't there it's considered "none" by both versions of the spec so just bumping the version could be enough, but it seems GNOME Software at least with the 1.0 spec doesn't seem to do that.
The switch to 1.1 may fix this but tbh I prefer an explicit approach. If required I can remove all "none" properties.
I don't know if it matches a goal in the roadmap but it improves app metadata on Linux's software centers.
To do
This PR is Ready for Review.
How to test
Read the patch, validate metainfo file. Check if it matches the OARS 1.1 spec.