DM-49274: Stop sky objects appearing in NO_DATA regions #369
Conversation
leeskelvin
force-pushed
the
tickets/DM-49274
branch
3 times, most recently
from
eb021ba to
89727b2
Compare
leeskelvin
force-pushed
the
tickets/DM-49274
branch
from
89727b2 to
9f890a5
Compare
| @@ -370,6 +370,7 @@ def __call__(self, data: KeyedData, **kwargs) -> Vector: | |||
| def setDefaults(self): | |||
| self.selectWhenFalse = [ | |||
| "{band}_pixelFlags_edge", | |||
| "{band}_pixelFlags_nodata", | |||
There was a problem hiding this comment.
Do you mind adding super().setDefaults() above this line while you're at it?
There was a problem hiding this comment.
Added into the setDefaults for SkyObjectSelector, SkySourceSelector, and GoodDiaSourceSelector. How does that read now @arunkannawadi?
There was a problem hiding this comment.
It reads great now. Thanks, Lee
| @@ -392,6 +393,7 @@ def __call__(self, data: KeyedData, **kwargs) -> Vector: | |||
| def setDefaults(self): | |||
| self.selectWhenFalse = [ | |||
| "pixelFlags_edge", | |||
| "pixelFlags_nodata", | |||
There was a problem hiding this comment.
Similarly super().setDefaults() here.
There was a problem hiding this comment.
See previous comment.
| self.assertEqual(DiaSourceCount["numAllDiaSources"].quantity.value, 558) | ||
| self.assertEqual(DiaSourceCount["numGoodDiaSources"].quantity.value, 547) | ||
| self.assertEqual(DiaSourceCount["ratioGoodToAllDiaSources"].quantity.value, 547 / 558) | ||
| self.assertEqual(DiaSourceCount["numAllDiaSources"].quantity.value, 2994) |
There was a problem hiding this comment.
This seems like a big change - any idea why?
There was a problem hiding this comment.
Yes - I didn't know the data ID that was used to generate the original dataset, so I guessed my own. This means that the output catalog has grown in size from the prior 558 entries to 2994. Undoubtedly, my data ID is not the same one that was used to generate the original test sample.
There was a problem hiding this comment.
OK that is fair! Whoever made that original dataset should have documented it better 😜 would you consider adding the script or similar you used to generate the test data for next time?
There was a problem hiding this comment.
I added my workflow into this Jira ticket comment: https://rubinobs.atlassian.net/browse/DM-49274?focusedCommentId=581302.
Is that a sufficient place to document this @mrawls?
There was a problem hiding this comment.
That is great - my initial thought was a text file or script of some kind in the new data subdirectory, but honestly having it on the Jira ticket is at least as good, thank you
leeskelvin
force-pushed
the
tickets/DM-49274
branch
from
9f890a5 to
bbff51f
Compare
leeskelvin
force-pushed
the
tickets/DM-49274
branch
from
bbff51f to
70fc07d
Compare
No description provided.