DM-48716: Investigate memory leak in the Watcher. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that all severities are NONE, after it has started to produce heartbeats . There is a race condition here that, when we enable the rule, before we are publishing heartbeat it will trigger the severity. So the most realiable order of operations is, start publishing heartbeats and then enable the alarm.
…ation is done. There is a race condition between a background task is cancelled and the actual cancelation is done. The test now will check it the escalation_timer_task is done, if it is it will assert that it was cancelled, if not it will await for the task and assert that it raises a CancelledError.
…lish an initial summaryState event for the ATDome CSC, used during the test. In DDS every unit test was fully isolated but this is no longer the case with Kafka. So, if we don't publish an initial summaryState the Watcher CSC ends up getting whatever last state was published for this component, which interferes with the unit test. To ensure this does not happen the best thing to do is publish a value of the summary state the CSC would be in.
teweitsai
approved these changes
Feb 18, 2025
| @@ -28,7 +28,7 @@ | |||
| STD_TIMEOUT = 5 # Max time to send/receive a topic (seconds) | |||
| LONG_TIMEOUT = 60 # Max Remote startup time (seconds) | |||
|
|
|||
| index_gen = utils.index_generator() | |||
| index_gen = utils.index_generator(imin=1234) | |||
There was a problem hiding this comment.
Please help to comment the fix here. I do not understand why the imin=1234 fixes the issue. Thanks!
|
For the remove of |
…tion at a higher range such that it does not overlap with other unit tests that ran previously.
…leak. Basically the original code passes a dictionary to the method and edits the dictionary in place. One have to be really carefull when doing this, especially as one would usually not expect that a passed argument be directly edited by a method. Furthermore, when an assignement is made, a local variable is created instead, which was the source of the memory leak.
tribeiro
force-pushed
the
tickets/DM-48716
branch
from
88a8f27 to
11d6400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to fixing the memory leak, improve unit test reliability and remove references to idl.