Add the rule of hexapod overcurrent event. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teweitsai
force-pushed
the
tickets/DM-48625
branch
2 times, most recently
from
4ba1e8d to
4ca9ffe
Compare
teweitsai
force-pushed
the
tickets/DM-48625
branch
from
4ca9ffe to
5d3e59c
Compare
tribeiro
reviewed
Feb 18, 2025
There was a problem hiding this comment.
This looks good, however, I think you can get away with not having to subclass a base class by making the Hexapod index/name a configuration parameters.
Also, check my inline comments about ensuring the count is bounded and about subtracting it to allow the rule to more gracefully transition from one alarm level to another.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.