Skip to content

Commit

Permalink
Feat/update to 24.04 (#21)
Browse files Browse the repository at this point in the history
* Update build.yml to use native runner

* Update C image to 24.04

* Update Rust image to 24.04

* Add build on PR

* Update build.yml to use versioned build-and-push-docker-image workflow

* Disable swift

* Remove date tag

---------

Co-authored-by: Robert Jandow <[email protected]>
  • Loading branch information
Mtze and robertjndw authored Jan 24, 2025
1 parent 4215ddb commit 1047194
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 21 deletions.
32 changes: 13 additions & 19 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,20 @@
on:
pull_request:
branches:
- master
push:
branches:
- master
workflow_dispatch:

jobs:
build-and-push-base:
uses: ls1intum/.github/.github/workflows/build-and-push-docker-image.yml@feat/docker-run-network
uses: ls1intum/.github/.github/workflows/build-and-push-docker-image.yml@v1.0.0
with:
docker-file: images/base-ide/BaseDockerfile
image-name: ghcr.io/ls1intum/theia/base
docker-context: .
tags: "2024-11-11"
tags: "2025-01-24"
network: "host"
secrets: inherit

Expand All @@ -24,46 +27,37 @@ jobs:
- docker-file: images/c/ToolDockerfile
docker-context: '.'
image-name: ghcr.io/ls1intum/theia/c
tags: "2024-11-11"
- docker-file: images/haskell/ToolDockerfile
docker-context: '.'
image-name: ghcr.io/ls1intum/theia/haskell
tags: "2024-11-11"
- docker-file: images/java-17/ToolDockerfile
docker-context: '.'
image-name: ghcr.io/ls1intum/theia/java-17
tags: "2024-11-11"
- docker-file: images/javascript/ToolDockerfile
docker-context: '.'
image-name: ghcr.io/ls1intum/theia/javascript
tags: "2024-11-11"
- docker-file: images/ocaml/ToolDockerfile
docker-context: '.'
image-name: ghcr.io/ls1intum/theia/ocaml
tags: "2024-11-11"
- docker-file: images/python/ToolDockerfile
docker-context: '.'
image-name: ghcr.io/ls1intum/theia/python
tags: "2024-11-11"
- docker-file: images/rust/ToolDockerfile
docker-context: '.'
image-name: ghcr.io/ls1intum/theia/rust
tags: "2024-11-11"
- docker-file: images/swift/ToolDockerfile
docker-context: '.'
image-name: ghcr.io/ls1intum/theia/swift
build-args: |
"BUILDER_IMAGE=swift:5.9.2-focal"
"RUNTIME_IMAGE=swift:5.9.2-focal"
"SWIFTLINT_VERSION=0.54.0"
tags: "2024-11-11"
# - docker-file: images/swift/ToolDockerfile
# docker-context: '.'
# image-name: ghcr.io/ls1intum/theia/swift
# build-args: |
# "BUILDER_IMAGE=swift:5.9.2-focal"
# "RUNTIME_IMAGE=swift:5.9.2-focal"
# "SWIFTLINT_VERSION=0.54.0"

uses: ls1intum/.github/.github/workflows/build-and-push-docker-image.yml@feat/docker-run-network
uses: ls1intum/.github/.github/workflows/build-and-push-docker-image.yml@v1.0.0
with:
docker-file: ${{ matrix.docker-file }}
image-name: ${{ matrix.image-name }}
docker-context: ${{ matrix.docker-context }}
tags: ${{ matrix.tags }}
network: "host"
secrets: inherit

Expand Down
2 changes: 1 addition & 1 deletion images/c/ToolDockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ RUN yarn --pure-lockfile --network-timeout 1000000 && \
# Assemble the application
# Adapted from https://github.com/ls1intum/artemis-c-docker/blob/main/Dockerfile
# Changed: Use theia user instead of artemis user, do not install python
FROM ubuntu:23.04 as final-ide
FROM ubuntu:24.04 as final-ide

Check warning on line 27 in images/c/ToolDockerfile

View workflow job for this annotation

GitHub Actions / build-and-push (images/c/ToolDockerfile, ., ghcr.io/ls1intum/theia/c) / Build Docker Image for ghcr.io/ls1intum/theia/c

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 27 in images/c/ToolDockerfile

View workflow job for this annotation

GitHub Actions / build-and-push (images/c/ToolDockerfile, ., ghcr.io/ls1intum/theia/c) / Build Docker Image for ghcr.io/ls1intum/theia/c

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

# Make sure all sources are up to date
RUN apt update && \
Expand Down
2 changes: 1 addition & 1 deletion images/rust/ToolDockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ RUN yarn --pure-lockfile --network-timeout 1000000 && \
yarn download:plugins

# Assemble the application
FROM ubuntu:23.04 as final-ide
FROM ubuntu:24.04 as final-ide

Check warning on line 25 in images/rust/ToolDockerfile

View workflow job for this annotation

GitHub Actions / build-and-push (images/rust/ToolDockerfile, ., ghcr.io/ls1intum/theia/rust) / Build Docker Image for ghcr.io/ls1intum/theia/rust

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 25 in images/rust/ToolDockerfile

View workflow job for this annotation

GitHub Actions / build-and-push (images/rust/ToolDockerfile, ., ghcr.io/ls1intum/theia/rust) / Build Docker Image for ghcr.io/ls1intum/theia/rust

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

# Make sure all sources are up to date
RUN apt update && \
Expand Down

0 comments on commit 1047194

Please sign in to comment.