Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication: Adapt communication search bar to reflect search targets #10583

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

julian-wls
Copy link
Contributor

@julian-wls julian-wls commented Mar 25, 2025

Checklist

General

Client

  • I strictly followed the client coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme..
  • I translated all newly inserted strings into English and German.

Motivation and Context

It is not quite clear which conversations are targeted by the conversation search.

Description

This PR changes the placeholder text to correctly reflect which conversations are searched.

Steps for Testing

Prerequisites:

  • 1 Student
  1. Log in to Artemis
  2. Go to the communication module
  3. See the new search bar hint

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Screenshots

image

@julian-wls julian-wls requested a review from a team as a code owner March 25, 2025 16:28
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Mar 25, 2025
@julian-wls julian-wls added communication Pull requests that affect the corresponding module small labels Mar 25, 2025
Copy link
Contributor

coderabbitai bot commented Mar 25, 2025

Walkthrough

This pull request updates the text for the searchBarDefault key in the overview section of both the German and English localization files. The modifications expand the search functionality description to explicitly include direct chats and groups, in addition to channels. There are no changes to the declarations of exported or public entities.

Changes

File(s) Summary of Changes
src/main/webapp/i18n/de/metis.json
src/main/webapp/i18n/en/metis.json
Updated the searchBarDefault string in the overview section to include "Direkt-Chats und Gruppen" (German) and "direct chats and groups" (English) for expanded search functionality.

Possibly related PRs

Suggested labels

documentation, client, small, ready to merge, component:Communication

Suggested reviewers

  • edkaya
  • pzdr7
  • krusche
  • asliayk

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 071ebf7 and 9157a2f.

📒 Files selected for processing (2)
  • src/main/webapp/i18n/de/metis.json (1 hunks)
  • src/main/webapp/i18n/en/metis.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`src/main/webapp/i18n/de/**/*.json`: German language translations should be informal (dutzen) and should never be formal (sietzen). So the user should always be addressed with "du/...

src/main/webapp/i18n/de/**/*.json: German language translations should be informal (dutzen) and should never be formal (sietzen). So the user should always be addressed with "du/dein" and never with "sie/ihr".

  • src/main/webapp/i18n/de/metis.json
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: Build and Push Docker Image / Build Docker Image for ls1intum/artemis
  • GitHub Check: Build and Push Docker Image / Build Docker Image for ls1intum/artemis
  • GitHub Check: Build .war artifact
  • GitHub Check: client-style
  • GitHub Check: client-tests
  • GitHub Check: server-tests
  • GitHub Check: server-style
  • GitHub Check: Analyse
🔇 Additional comments (2)
src/main/webapp/i18n/en/metis.json (1)

72-74: Expanded Search Placeholder Text is Clear and Informative
The updated string now explicitly informs users that the search functionality covers channels, direct chats, and groups. This change clearly aligns with the PR objective. Ensure that the UI components correctly reflect the new text and that no legacy references to the old placeholder remain.

src/main/webapp/i18n/de/metis.json (1)

72-74: Updated German Placeholder Text is Accurate and Informal
The revised text now reads "Suche nach Nachrichten in allen Kanälen, Direkt-Chats und Gruppen (Strg/Cmd + K)", which not only meets the requirement to expand the search scope but also adheres to the informal tone guidelines for German translations. Verify that this string is consistently used in the UI and that no formal language slips in elsewhere.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@FelberMartin FelberMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search hint is more explicit now

Copy link
Contributor

@asliayk asliayk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) communication Pull requests that affect the corresponding module small
Projects
Status: Work In Progress
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants