Integrated code lifecycle: Unify ssh usage config condition for build agents

[jfr2102]

Checklist

General

• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• I chose a title conforming to the naming conventions for pull requests.

Server

• I strictly followed the server coding and design guidelines.
• I documented the Java code using JavaDoc style.

Motivation and Context

While trying to find right configuration values I found the current behaviour of config artemis.version-control.build-agent-use-ssh quite confusing.
artemis.version-control.build-agent-use-ssh actually only controls wether a keypair will be generated at the startup of an buildagent and what the getPublicKeyAsString() method returns (this result is stored in the hazelcast map where core nodes can read it).

However, the actual condition wether the build agent will configure ssh in the BuildJobGitService currently depends on the useSsh() method in the parent AbstractGitService which returns true if the 2 configuration values ssh-host-key-path and ssh-template-clone-url are present.

Currently configuringbuild-agent-use-ssh: false but ssh-host-key-path and ssh-template-clone-url being present will not create a keypair, and not push the public key into the hazelcast store, but still try configure ssh on the build agent.

If keys get manually generated in the configured ssh-template-clone-url and this build-agent-use-ssh is supposed to just prevent the creation of a new key then build-agent-use-ssh:false would also prevent public key being put into hazelcast (because getPublicKeyAsString() returns null then.) Which seems weird.

Description

I suggest to override useSsh() in BuildJobGitService to check on configuration build-agent-use-ssh to be consistent with the conditions for generating the keypair and throwing a RuntimeException if build-agent-use-ssh:true but no ssh-template-clone-url is set

Steps for Testing

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Test Coverage

Screenshots