Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support embeddings on dark background #126

Closed
wants to merge 2 commits into from

Conversation

farisd16
Copy link
Member

@farisd16 farisd16 commented Jan 5, 2025

This PR removes the white background from embeddings in case the editor was in dark mode at the time of sharing the diagram.

@FelixTJDietrich
Copy link
Contributor

FelixTJDietrich commented Feb 3, 2025

Test:
New shared version

Copy link
Contributor

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how it looks when I embed it in dark mode but view it in light mode on GitHub:
image

See for yourself in my comment.
You would need to have a black line with white outline or the other way around. Or like a black and white line next to each other so you can see it regardless of the appearance selected on GitHub.

Please also add testing instructions and test if for yourself with the test server. You can deploy your branch here https://github.com/ls1intum/Apollon_standalone/actions via the Deploy to Dev workflow.

@farisd16
Copy link
Member Author

The intention was to export the diagram for dark/light mode depending on the mode currently used in the standalone Apollon editor. I agree that is not an optimal solution and can lead to confusion. I will close the PR therefore.

@farisd16 farisd16 closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants