[sw] Simplify lifecycle checks in immutable rom ext #26260
+52
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasdf
force-pushed
the
mgI33ea6148
branch
3 times, most recently
from
2b7322f to
4bd5eab
Compare
The commit simplifies the existing check in immutable ROM_EXT, which determines whether to enable the RvDM ePMP region based on the lifecycle state (prod / non-prod). The simplified check only tests for PROD and PROD-END states to reduce space cost by eliminating TEST-UNLOCK states checks. One potential downside is that invalid LCS states will be treated as non-prod, leading to the RvDM region being enabled. However, this is mitigated by the fact that debugging requires JTAG, which verifies LCS in hardware. Additionally, invalid LCS will be detected later in the mutable ROM_EXT stage when reading the lifecycle. Change-Id: I33ea6148f7e36f7c1bc87b5a150ae783c545ffc2 Signed-off-by: Yi-Hsuan Deng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit simplifies the existing check in immutable ROM_EXT, which determines whether to enable the RvDM ePMP region based on the lifecycle state (prod / non-prod). The simplified check only tests for PROD and PROD-END states to reduce space cost by eliminating TEST-UNLOCK states checks.
One potential downside is that invalid LCS states will be treated as non-prod, leading to the RvDM region being enabled. However, this is mitigated by the fact that debugging requires JTAG, which verifies LCS in hardware. Additionally, invalid LCS will be detected later in the mutable ROM_EXT stage when reading the lifecycle.