[testing] Add a test for parallel ECDSA/SPX verify #26255
+5,035
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moidx
approved these changes
Feb 12, 2025
sw/device/silicon_creator/rom/rom.c
Outdated
| &rev_digest, flash_exec); | ||
| } | ||
|
|
||
| HARDENED_RETURN_IF_ERROR(sigverify_ecdsa_p256_start( |
There was a problem hiding this comment.
This change is a good candidate for master, but I think we can leave from earlgrey_1.0.0 for now.
There was a problem hiding this comment.
ack. Added to my list.
cfrantz
force-pushed
the
spx-in-parallel-test
branch
from
d12269a to
a2b8409
Compare
jadephilipoom
approved these changes
Feb 14, 2025
Split ECDSA sigverify into start and finish operations so Ibex and execute code while OTBN is verifying the signature. Signed-off-by: Chris Frantz <[email protected]>
Signed-off-by: Chris Frantz <[email protected]>
Signed-off-by: Chris Frantz <[email protected]>
Guard the "raw data" section of the hexdump with pipe characters (`|`). Sometimes hexdumps contain ASCII space or ASCII backslash as the last character of the raw data section. This runs afoul of our formatting rules or causes the slash-style comments to have an end-of-line continuation. Signed-off-by: Chris Frantz <[email protected]>
Signed-off-by: Chris Frantz <[email protected]>
cfrantz
force-pushed
the
spx-in-parallel-test
branch
from
a2b8409 to
919a312
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR depends on #26160. You need only review the last two commits.