Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hmac,dv] Adjust again reseed for NIST #26249

Merged
merged 1 commit into from
Feb 12, 2025
Merged

[hmac,dv] Adjust again reseed for NIST #26249

merged 1 commit into from
Feb 12, 2025

Conversation

martin-velay
Copy link
Contributor

  • Regression was still showing holes sometimes despite of the last reseed increase. SHA-2 384/512 tests have 129 short vectors + 128 long vectors. This is a total of 257 vectors. That's the reason why the reseed is higher than for the others (HMAC_SHA-2_512 has 225 vectors, HMAC_SHA-2_384 has 180 and SHA-2_256 has 64 longs + 65 shorts).

@martin-velay
[hmac,dv] Adjust again reseed for NIST
0110dde 
- Regression was still showing holes sometimes despite of the last
  reseed increase. SHA-2 384/512 tests have 129 short vectors + 128 long
  vectors. This is a total of 257 vectors. That's the reason why the
  reseed is higher than for the others (HMAC_SHA-2_512 has 225 vectors,
  HMAC_SHA-2_384 has 180 and SHA-2_256 has 64 longs + 65 shorts).

Signed-off-by: Martin Velay <[email protected]>
@martin-velay martin-velay self-assigned this Feb 11, 2025
@martin-velay martin-velay added Component:DV DV issue: testbench, test case, etc. IP:hmac labels Feb 11, 2025
@martin-velay martin-velay marked this pull request as ready for review February 12, 2025 09:21
@martin-velay martin-velay requested a review from a team as a code owner February 12, 2025 09:21
@martin-velay
Copy link
Contributor Author

The latest regression from this night doesn't show any hole this time

@rswarbrick rswarbrick merged commit 6f8c069 into lowRISC:master Feb 12, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rswarbrick rswarbrick rswarbrick approved these changes

@vogelpi vogelpi Awaiting requested review from vogelpi

Assignees

@martin-velay martin-velay

Labels
Component:DV DV issue: testbench, test case, etc. IP:hmac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-velay @rswarbrick