[sw,multitop] port hmac_enc_test to devicetables #26244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJones0
requested review from
HU90m,
pamaury,
nbdd0121 and
jwnrt
and removed request for
a team and
HU90m
AlexJones0
force-pushed
the
dt_hmac_enc
branch
2 times, most recently
from
97d43ca to
aae4868
Compare
nbdd0121
reviewed
Feb 11, 2025
Comment on lines
+43
to
+60
| // Claim the IRQ at the PLIC. | ||
| dif_rv_plic_irq_id_t plic_irq_id; | ||
| CHECK_DIF_OK(dif_rv_plic_irq_claim(&rv_plic, kPlicTarget, &plic_irq_id)); | ||
|
|
||
| // Get the peripheral the IRQ belongs to, and the ID of the IRQ fired | ||
| peripheral_serviced = dt_plic_id_to_instance_id(plic_irq_id); | ||
| dt_hmac_irq_t irq = dt_hmac_irq_from_plic_id(kHmacDt, plic_irq_id); | ||
| irq_serviced = irq; | ||
|
|
||
| // Acknowledge the IRQ at the peripheral if the IRQ is of the event type. | ||
| dif_irq_type_t type; | ||
| CHECK_DIF_OK(dif_hmac_irq_get_type(&hmac, irq, &type)); | ||
| if (type == kDifIrqTypeEvent) { | ||
| CHECK_DIF_OK(dif_hmac_irq_acknowledge(&hmac, irq)); | ||
| } | ||
|
|
||
| // Complete the IRQ at the PLIC. | ||
| CHECK_DIF_OK(dif_rv_plic_irq_complete(&rv_plic, kPlicTarget, plic_irq_id)); |
There was a problem hiding this comment.
Hmm, not sure about the best thing to do, but I don't think duplicating ISR testutils is ideal.. If we do this for each IP then we will end up with a lot of verbose code.
There was a problem hiding this comment.
I told @AlexJones0 to do that for now because the isr testutils are not ported to multitop yet. Also as an aside, the isr testutils as defined just don't make sense, we should probably change them.
There was a problem hiding this comment.
We could also keep this PR open until we have ported the testutils.
The `isr_testutils` API is not yet ported to DT, and this test only uses a small subset of the functionality exposed by `isr_testutils_hmac_isr`. So, for this test, we manually replace this function call with a few lines of equivalent dt code to keep the test passing. Since we no longer use `isr_testutils`, this drops the corresponding `isr_ctx` and `hmac_ctx` structs in favour of simplifying the test implementation. Signed-off-by: Alex Jones <[email protected]>
AlexJones0
force-pushed
the
dt_hmac_enc
branch
from
aae4868 to
c019c67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #26215
This PR ports the
hmac_enc_testto use the devicetables API so that it no longer depends on Earlgrey-specific constants. The test remains passing on Earlgrey on FPGA (fpga_cw310_rom_with_fake_keys), and will compile for Darjeeling viaSee the commit message for more details about replacing the
isr_testutilsAPI call.