Cherry-pick to earlgrey_1.0.0: Immutable rom ext related changes #26144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothytrippel
approved these changes
Feb 6, 2025
cfrantz
requested changes
Feb 6, 2025
|
This should be mergable now; @cfrantz could you re-review to unblock? |
Immutable rom_ext also needs the epmp lib for reconfiguration. Since the library code is general and not specific to rom_ext, let's move it to driver lib. Signed-off-by: Yi-Hsuan Deng <[email protected]> (cherry picked from commit ee7fa49)
To minimize the divergence between SKUs that with and without immutable rom_ext feature enabled in ROM, we propose always linking the section to rom_ext, and call it first if it isn’t called by ROM. With this change, the boot flows will be always (almost) the same, while the OTP flag `IMMUTABLE_ROM_EXT_EN` basically only controls whether the immutability is enforced by ROM. SKUs without the immutability enforced enable should still link with the trunk/master imm_rom_ext section, but without the EN bit set in their OTP configuration. Signed-off-by: Yi-Hsuan Deng <[email protected]> (cherry picked from commit db977a5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR manually cherrypick the preparatory refactoring commits about immutable rom ext to earlgrey_1.0.0 branch.
Includes
There is only extra syntactical fixup (i.e. wrong indent) compared to the original commit in master.