Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Illegal instruction display message #2261

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Conversation

ha0lyu
Copy link
Contributor

@ha0lyu ha0lyu commented Mar 26, 2025

Fix #2236 When encountering certain illegal compressed instructions, incorrect instruction information was displayed. Now, illegal instructions can be printed correctly.

When encountering certain illegal compressed instructions, incorrect instruction information was displayed. Now, illegal instructions can be printed correctly.
@ha0lyu ha0lyu mentioned this pull request Mar 26, 2025
Copy link
Contributor

@marnovandermaas marnovandermaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct, leaving to @rswarbrick to approve because he was involved in the discussion before.

Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me. Thanks!

@rswarbrick rswarbrick added this pull request to the merge queue Mar 26, 2025
Merged via the queue into lowRISC:master with commit 2678654 Mar 26, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simulator report error
3 participants