Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support base64 encoded api key #1207

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Mar 19, 2025

fixes #1064

@yaauie
Copy link
Contributor

yaauie commented Mar 20, 2025

build failure is unrelated; something in our dependency graph no longer causes this plugin's open-ended development dependency on elasticsearch to resolve to 7.x, so we get 8.x and fail.

EDIT: it's logstash-core 8.17+ that now relies on elasticsearch ~>8 😩, so the build is just plain broken.

We'll need to either:

  • (a) update this code to use the v8 es client (which is not backward-compatible with older ES's); OR
  • (b) update all tests to http at elasticsearch manually.

@mashhurs
Copy link
Contributor

build failure is unrelated; something in our dependency graph no longer causes this plugin's open-ended development dependency on elasticsearch to resolve to 7.x, so we get 8.x and fail.

EDIT: it's logstash-core 8.17+ that now relies on elasticsearch ~>8 😩, so the build is just plain broken.

We'll need to either:

  • (a) update this code to use the v8 es client (which is not backward-compatible with older ES's); OR
  • (b) update all tests to http at elasticsearch manually.

Sorry for that! #1208 fixes the CI failures.
I have opened an issue to remove elasticsearch-ruby v7 sources once LS-core fully moves to v8 version.

@mashhurs mashhurs force-pushed the support_b64_api_key branch from a090428 to 86c1203 Compare March 21, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support base64 encoded Api Key
3 participants