Fixed minor issues in printhelper.go #2514
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
lizardruss
requested changes
Feb 21, 2025
| @@ -29,8 +29,8 @@ EXTERNAL-IP may be 'pending' for a while until your cloud provider has created a | |||
|
|
|||
| ######################################################################################################### | |||
|
|
|||
| The command will wait until loft is reachable under the host. You can also abort and use port-forwarding instead | |||
| by running 'loft start' again. | |||
| The command will wait until vcluster platform is reachable under the host. You can also abort and use port-forwarding instead | |||
There was a problem hiding this comment.
I'm basing this suggestion on vcluster-docs style guide, but you may want to confirm what we want to use in this context. I also think vCluster Platform might be acceptable.
Suggested change
| The command will wait until vcluster platform is reachable under the host. You can also abort and use port-forwarding instead | |
| The command will wait until the platform is reachable under the host. You can also abort and use port-forwarding instead |
There was a problem hiding this comment.
We want to refer the the platform as the platform but since this is a CLI helper vCluster platform is also ok.
| @@ -54,10 +54,10 @@ Login via CLI: %s | |||
|
|
|||
| ################################################################# | |||
|
|
|||
| Loft was successfully installed and port-forwarding has been started. | |||
| If you stop this command, run 'loft start' again to restart port-forwarding. | |||
| vcluster platform was successfully installed and port-forwarding has been started. | |||
There was a problem hiding this comment.
Suggested change
| vcluster platform was successfully installed and port-forwarding has been started. | |
| The platform was successfully installed and port-forwarding has been started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind documentation
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)This pr fixes commands and some old references of loft changed to vcluster platform in printhelper.go