[v0.23] bugfix: objectname validation in from host mappings should be DNSSubdomain (#2502) #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omain (#2502) Signed-off-by: Paweł Bojanowski <[email protected]> (cherry picked from commit 515ef85)
hidalgopl
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from
maintov0.23Original PR Nr.: #2502
Backported Commits:
Signed-off-by: Paweł Bojanowski <[email protected]>
Original PR Description:
…omain
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
/kind test
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-5876
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where validation of from host sync mappings was rejecting valid object names
What else do we need to know?