fix: Check if vcluster is reachable with the additional flags provided as input in vcluster connect command
#2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
kale-amruta
changed the title
vcluster connect command
…d using the kubeconfig.
kale-amruta
force-pushed
the
serverflagCheck
branch
from
04d89aa to
3505235
Compare
kale-amruta
changed the title
vcluster connect commandvcluster connect command
kale-amruta
changed the title
vcluster connect commandvcluster connect command
lizardruss
requested changes
Jan 27, 2025
johannesfrey
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-5488
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where
vcluster connectcommand was giving positive result even when vcluster is not exposed on the endpoint provided inserverflagWhat else do we need to know?
With this PR, the
vcluster connectcommand will perform an additional check of verifying the vcluster is accessible with the additional flags that are provided in the command. This is done by checking if we are able to list thedefaultservice account is in the vcluster.eg:
vcluster connect --serverwill verify if vcluster is accessible from the endpoint specified in--serverflag