Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow Composer plugin tbachert/spi to run by default #192

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Don't allow Composer plugin tbachert/spi to run by default #192

merged 1 commit into from
Feb 18, 2025

Conversation

stephen-cox
Copy link
Member

Fixes #191

What does this change?

Explicitly deny the tbachert/spi Composer plugin.

How to test

Run a composer update and don't see the message asking you whether you trust this plugin or now.

millnut
millnut approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@millnut millnut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this comes from the open-telemetry/sdk which we don't have plans to use currently and if people do want it they can switch it to true

@finnlewis finnlewis merged commit 873d0ae into 3.x Feb 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millnut millnut millnut approved these changes

@ekes ekes Awaiting requested review from ekes

@andybroomfield andybroomfield Awaiting requested review from andybroomfield

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't allow Composer plugin tbachert/spi to run by default
3 participants
@stephen-cox @millnut @finnlewis