Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ddev config to use PHP 8.3 by default. #188

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Update ddev config to use PHP 8.3 by default. #188

merged 1 commit into from
Jan 21, 2025

Conversation

finnlewis
Copy link
Member

Resolves #187

Sets PHP to 8.3 in ddev default config.

@finnlewis
Copy link
Member Author

I note that the failing coding standards test is fixed in localgov_guides: localgovdrupal/localgov_guides@859add3

So we just need a release of localgov_guides to address that failure.

ekes
ekes approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@ekes ekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this for a final ok tomorrow at Merge Tuesday. More for visibility.

@finnlewis finnlewis merged commit 9aa8f1e into 3.x Jan 21, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekes ekes ekes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update DDEV config for PHP 8.3
2 participants
@finnlewis @ekes