Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add max tokens for open-ended completion #34

Merged
merged 2 commits into from
Feb 27, 2025
Merged

add max tokens for open-ended completion #34

merged 2 commits into from
Feb 27, 2025

Conversation

neilmehta24
Copy link
Member

No description provided.

@neilmehta24 neilmehta24 requested a review from yagil February 27, 2025 17:03
yagil
yagil approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@yagil yagil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition. Can you please add this to TypeScript as well?

@github-actions github-actions bot added the CLA signed Indicates that all contributors have signed label Feb 27, 2025
@neilmehta24 neilmehta24 requested a review from yagil February 27, 2025 22:23
@neilmehta24 neilmehta24 merged commit 7cde46f into dev Feb 27, 2025
1 check passed
@neilmehta24 neilmehta24 deleted the neil/limit-completion branch February 27, 2025 22:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yagil yagil Awaiting requested review from yagil

Assignees
No one assigned
Labels
CLA signed Indicates that all contributors have signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neilmehta24 @yagil