[TorchToLinalg] Merge indices and pooling computation into one linalg generic op #3701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lingzhiz1998
force-pushed
the
lingzhi/reimplement_maxpoolwithindices
branch
from
1bd975c
to
ae1fa20
Compare
|
@vivekkhandelwal1 any comments? Thanks! |
Let me review it thoroughly today. I will respond after that. |
There was a problem hiding this comment.
Hi @zjgarvey, can you please review this PR when you get time? Since for me it's really hard to understand what are we trying to achieve through these changes. I think you asked for this (probably?) here #3652 (review). I'm slightly concerned about introducing scf.if op and whether that's actually required or not.
Excluding this, there are only 2 Torch->Linalg lowering which contains op from the scf dialect, one of which is multinomial which Mahesh was saying that should not have been lowered that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #3652, we should use one linalg generic op to represent maxpool with indices op.