[onnx] Decompose onnx.Adam into elementwise operations
#3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can support `onnx.Adam` by decomposing into elementwise operations. The numerics slightly differ from `onnxruntime` however they appear to be within margins.
vivekkhandelwal1
requested changes
Sep 11, 2024
Comment on lines
+156
to
+160
| float alpha = 0.9; | ||
| float beta = 0.999; | ||
| float epsilon = 0.0; | ||
| float norm = 0.0; | ||
| float postNorm = 0.0; |
There was a problem hiding this comment.
Is there a need to initialize all of them since the default value would be assigned during the binding itself? Also, can we declare them all in the same line?
Comment on lines
+172
to
+175
| SmallVector<Value> inputs; | ||
| SmallVector<Value> grads; | ||
| SmallVector<Value> accGrads; | ||
| SmallVector<Value> accSqGrads; |
There was a problem hiding this comment.
Same here for declaration.
Comment on lines
+242
to
+251
| SmallVector<Value> newX; | ||
| SmallVector<Value> newG; | ||
| SmallVector<Value> newSG; | ||
|
|
||
| for (int i = 0, s = inputs.size(); i < s; ++i) { | ||
|
|
||
| Value x = inputs[i]; | ||
| Value g = grads[i]; | ||
| Value v = accGrads[i]; | ||
| Value h = accSqGrads[i]; |
There was a problem hiding this comment.
Same here as above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can support
onnx.Adamby decomposing into elementwise operations. The numerics slightly differ fromonnxruntimehowever they appear to be within margins.