Prevent UnifiedTreeBuilder producing step names over 50 characters in length #293
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ength Upstream buildbot releases error if a step name has over 50 characters long <buildbot/buildbot#3414>. UnifiedTreeBuilder can produce quite long step names that violate this, meaning it's difficult to spin up a local test environment (as in <llvm#289>) without local hacks to workaround this. In this patch, we simply truncate step names at creation time. This means llvm-zorg's buildbot config can be used with an unmodified upstream buildbot package.
|
Just for reference, these are the errors you get trying to start a buildmaster (or just checkconfig) on upstream buildbot without this fix: |
asb
added a commit
to asb/llvm-project
that referenced
this pull request
Nov 5, 2024
Once <llvm/llvm-zorg#289> and <llvm/llvm-zorg#293> land, it's quite reasonable to ask people to test their builder configurations locally. This patch adds documentation on how to do so. I think review at this stage is useful, but of course if there's more review feedback on <llvm/llvm-zorg#289> it's possible some details may change. This won't be committed until those llvm-zorg PRs land of course.
asb
added a commit
to asb/llvm-project
that referenced
this pull request
Nov 5, 2024
Once <llvm/llvm-zorg#289> and <llvm/llvm-zorg#293> land, it's quite reasonable to ask people to test their builder configurations locally. This patch adds documentation on how to do so. I think review at this stage is useful, but of course if there's more review feedback on <llvm/llvm-zorg#289> it's possible some details may change. This won't be committed until those llvm-zorg PRs land of course.
| # <https://github.com/buildbot/buildbot/issues/3414>. | ||
| def trunc50(name): | ||
| if len(name) > 50: | ||
| return name[:47] + "..." |
There was a problem hiding this comment.
I was going to suggest f"{s:.47s}..." but this adds ... regardless of length, so don't do that.
Just mentioning that in case someone else was thinking of that.
asb
added a commit
that referenced
this pull request
Nov 8, 2024
This makes it (relatively) easy to test a builder setup locally. The buildmaster and the web interface should be bound only to local interfaces for security reasons (you can use ssh port forwarding if wanting to run on a server). See llvm/llvm-project#115024 for instructions on how to use, but note #293 is needed to avoid disabling certain builders or needing to hack your local buildbot install.
|
Ping? |
DavidSpickett
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
LGTM.
Whilst folks might be looking at the step names to see what they do at a glance, if the name is truncated then they can look at the start of the log for that step instead.
(and for complicated builds, it's often better to look at the log file as the step name may not be accurate anyway)
asb
added a commit
to llvm/llvm-project
that referenced
this pull request
Nov 12, 2024
…#115024) With <llvm/llvm-zorg#289> and <llvm/llvm-zorg#293> landed, it's now reasonable to ask people to test their builder configurations locally. This patch adds documentation on how to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream buildbot releases error if a step name has over 50 characters long buildbot/buildbot#3414. UnifiedTreeBuilder can produce quite long step names that violate this, meaning it's difficult to spin up a local test environment (as in #289) without local hacks to workaround this.
In this patch, we simply truncate step names at creation time. This means llvm-zorg's buildbot config can be used with an unmodified upstream buildbot package.