-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SingleSource/Vectorizer] Add unit tests for FindLastIV pattern. #193
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but wait for couple days for others to review
@fhahn @Meinersbur Do you have any suggestions and comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as for, do we need smaller types to trigger epilogue vectorization on more platforms?
IIUC llvm/llvm-project#120395 will need to be fixed first, otherwise the new tests will fail?
Sure, could you take a look at AnyOf #195 to see if the approach is appropriate? I will modify this patch in the same way if you feel good.
Yes, the current implementation still produces incorrect output in the following datasets after enabling epilogue vectorization.
llvm/llvm-project#120395 can fix this error. |
236e4be
to
f8c2b31
Compare
Add test for FFindLastIV, and s16 type for triggering epilogue vectorization easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This patch adds runtime test case for vectorization of FindLastIV reduction idiom:
Improving test coverage for llvm/llvm-project#67812 and llvm/llvm-project#120395.