Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler-rt] Add support for big endian for Arm's __negdf2vfp #127096

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

vhscampos
Copy link
Member

In soft floating-point ABI, this function takes the double argument as a pair of registers r0 and r1.

The ordering of these two registers follow the endianness rules, therefore the register on which the bit flipping must happen depends on the endianness.

In soft floating-point ABI, this function takes the double argument as a
pair of registers r0 and r1.

The ordering of these two registers follow the endianness rules,
therefore the register on which the bit flipping must happen depends on
the endianness.
Copy link
Collaborator

@statham-arm statham-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks for also making the immediate value more legible while you were at it!

@vhscampos vhscampos merged commit 43d308d into llvm:main Feb 17, 2025
10 checks passed
@vhscampos vhscampos deleted the negdf2vfp-big-endian branch February 17, 2025 11:43
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this pull request Feb 24, 2025
…127096)

In soft floating-point ABI, this function takes the double argument as a
pair of registers r0 and r1.

The ordering of these two registers follow the endianness rules,
therefore the register on which the bit flipping must happen depends on
the endianness.
simpal01 added a commit to simpal01/arm-toolchain that referenced this pull request Feb 28, 2025
…27096 and #127662

We need to incorporate the following upstreamed patches into the 20.x branch.
So applying these as patch files.

[compiler-rt] Add support for big endian for Arm's __negdf2vfp -
(cherry picked from llvm/llvm-project#127096)

[compiler-rt] Fix tests of _aeabi(idivmod|uidivmod|uldivmod) to support big endian -
(cherry picked from llvm/llvm-project#126277)

[libcxx] Work around picolibc argv handling in tests -
(cherry picked from llvm/llvm-project#127662)
simpal01 added a commit to arm/arm-toolchain that referenced this pull request Feb 28, 2025
…27096 and #127662 (#140)

We need to incorporate the following upstreamed patches into the 20.x
branch. So applying these as patch files.

[compiler-rt] Add support for big endian for Arm's __negdf2vfp - (cherry
picked from llvm/llvm-project#127096)

[compiler-rt] Fix tests of _aeabi(idivmod|uidivmod|uldivmod) to support
big endian - (cherry picked from
llvm/llvm-project#126277)

[libcxx] Work around picolibc argv handling in tests - (cherry picked
from llvm/llvm-project#127662)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants