[Transforms][circt-synth] Add HierarchicalRunner pass #8254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new pass that allows running passes under hierarchy. This is useful when we want to run synthesis passes only on real designs. This implementation is based on MLIR's upstream CompositePass and Inliner utilities. The pass takes a pipeline string and runs it on modules in the design hierarchy. It supports configurable options including the pipeline to run under hierarchy, the name of the top-level module, and whether to include bound instances in the hierarchy traversal. The implementation updates circt-synth tool with the required library dependencies and necessary dialect and pass headers.
Max-astro
reviewed
Feb 24, 2025
Comment on lines
+88
to
+90
| auto *node = worklist.pop_back_val(); | ||
| if (!node) | ||
| continue; |
There was a problem hiding this comment.
I'm curious about the pop-out node. In what situation will it be nullptr?
| for (auto *child : *node) { | ||
| auto childOp = child->getInstance(); | ||
| if (!childOp || | ||
| (!includeBoundInstances && childOp->hasAttr("doNotPrint"))) |
There was a problem hiding this comment.
Does the "doNotPrint" attribute have the same semantics as "set_dont_touch" in SDC?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new pass that allows running passes under hierarchy. This is useful when we want to run synthesis passes only on real designs.
This implementation is based on MLIR's upstream CompositePass and Inliner utilities. The pass takes a pipeline string and runs it on modules in the design hierarchy. It supports configurable options including the pipeline to run under hierarchy, the name of the top-level module, and whether to include bound instances in the hierarchy traversal.
The implementation updates circt-synth tool with the required library dependencies and necessary dialect and pass headers.