[COMB] Get rid of "bin" flag in comb. #8180
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wn binary values.
|
@uenoku can you look at the failing aig test? |
darthscsi
changed the title
This fixes a bug in CombToAIG that incorrectly removes `revert` flag. Also bin flag change caused some reordering for some reason so test is updated
|
@darthscsi fixed CombToAIG and test. |
|
This is fantastic 🥳💯! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define the truth tables for known binary values. Comp can simplify any expression according to binary truth tables. Unknown values and non-binary values are handled in a common way. This mostly matches verilog's 4-state truth tables. Where verilog-specific behavior is desired and it is not a consequence of binary truth tables, additional ops must be used. Propagation of runtime non-binary values are the responsibility of the execution environment.