Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCFToCalyx] Wrap blocks with scf::ExecuteRegion when creating the new scf::Parallel #8098

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

jiahanxie353
Copy link
Contributor

This patch adjusts the current approach to lower scf::parallel operation, which used to be illegal because it contains multiple blocks in the body region. Now we use a legal way by wrapping those blocks with scf::execute_region so that the newly create scf::parallel op contain exactly one block in the body region.

@jiahanxie353 jiahanxie353 self-assigned this Jan 20, 2025
@jiahanxie353 jiahanxie353 added the Calyx The Calyx dialect label Jan 20, 2025
Copy link
Member

@cgyurgyik cgyurgyik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments, LGTM when they're addressed. Please close the issue upon submission if this fixes it too.

@jiahanxie353
Copy link
Contributor Author

Thanks for the review, @cgyurgyik ! Merging it as the CI has passed.
Still need to insert an scf::if canonicalization pass to fully address #8086

@jiahanxie353 jiahanxie353 merged commit 6cfac8c into llvm:main Jan 20, 2025
5 checks passed
@jiahanxie353 jiahanxie353 deleted the par-execute-region branch February 23, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Calyx The Calyx dialect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants