Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESI] Snoop op #8096

Merged
merged 1 commit into from
Jan 21, 2025
Merged

[ESI] Snoop op #8096

merged 1 commit into from
Jan 21, 2025

Conversation

teqdruid
Copy link
Contributor

The 'snoop' operation allows something to spy on a channel. It simply exposes the internal signals combinationally.

The 'snoop' operation allows something to spy on a channel. It simply
exposes the internal signals combinationally.
@teqdruid teqdruid added the ESI label Jan 18, 2025
@teqdruid teqdruid requested a review from mortbopet January 18, 2025 03:34
@teqdruid
Copy link
Contributor Author

I'm sure I missed a few places where channel users are checked, but I can't make anything fail.

@mortbopet
Copy link
Contributor

Why have specialized snoop operations for each signaling standard (snoop.vr)?. As opposed to having a snoop op which returns an esi.channel that you unwrap. Then it's all in the lowerings to properly source/sink that esi.channel that is returned by the snoop op, s.t. it doesn't interact with the transactional signals of the snooped link - and, in lower ESI to HW, wrt. the snoop <-> channel interaction, you'd have only a single case to check.

@teqdruid
Copy link
Contributor Author

teqdruid commented Jan 19, 2025 via email

@teqdruid teqdruid merged commit c775dcf into main Jan 21, 2025
5 checks passed
@teqdruid teqdruid deleted the teqdruid/esi/snoop branch January 21, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants