Skip to content

Commit

Permalink
[1.x] Supports PHP 8.4 (#124)
Browse files Browse the repository at this point in the history
* Fix code styling

* [1.x] Supports PHP 8.4

* Update tests.yml

* Update tests.yml

---------

Co-authored-by: crynobone <[email protected]>
  • Loading branch information
crynobone and crynobone authored Nov 12, 2024
1 parent 135e6b3 commit 9efa7bd
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
14 changes: 8 additions & 6 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@ jobs:
strategy:
fail-fast: true
matrix:
php: [8.1, 8.2, 8.3]
php: [8.1, 8.2, 8.3, 8.4]
laravel: [10, 11]
exclude:
- php: 8.4
laravel: 10
- php: 8.1
laravel: 11

Expand All @@ -42,8 +44,7 @@ jobs:

- name: Install dependencies
run: |
composer require "illuminate/contracts=^${{ matrix.laravel }}" --no-update
composer update --prefer-dist --no-interaction --no-progress
composer update --prefer-dist --no-interaction --no-progress --with="laravel/framework:^${{ matrix.laravel }}"
- name: Execute tests
run: vendor/bin/pest
Expand All @@ -54,9 +55,11 @@ jobs:
strategy:
fail-fast: true
matrix:
php: [8.1, 8.2, 8.3]
php: [8.1, 8.2, 8.3, 8.4]
laravel: [10, 11]
exclude:
- php: 8.4
laravel: 10
- php: 8.1
laravel: 11

Expand Down Expand Up @@ -86,8 +89,7 @@ jobs:

- name: Install dependencies
run: |
composer require "illuminate/contracts=~${{ matrix.laravel }}" --no-update
composer update --prefer-dist --no-interaction --no-progress
composer update --prefer-dist --no-interaction --no-progress --with="laravel/framework:~${{ matrix.laravel }}"
- name: Execute tests
run: vendor/bin/pest
2 changes: 1 addition & 1 deletion tests/Feature/Actions/ResolveListenersTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use Livewire\Volt\Component;
use Livewire\Volt\InlineListenerName;

use function Livewire\Volt\{on};
use function Livewire\Volt\on;

it('resolves the registered listeners', function () {
$context = CompileContext::instance();
Expand Down

0 comments on commit 9efa7bd

Please sign in to comment.