Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding UtteranceEnd support for Deepgram #737

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hackyon
Copy link

@hackyon hackyon commented Sep 10, 2024

Adding support for UtteranceEnd to Deepgram agent plugin. The UtteranceEnd is another feature offered by Deepgram to detect end of speech.

The Deepgram documentation is here:
https://developers.deepgram.com/docs/utterance-end

Copy link

changeset-bot bot commented Sep 10, 2024

⚠️ No Changeset found

Latest commit: 90ab6cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -63,6 +64,7 @@ def __init__(
smart_format: bool = True,
no_delay: bool = True,
endpointing_ms: int = 25,
utterance_end_ms: int | None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, can you default it to None?

@@ -391,6 +401,12 @@ def _process_stream_event(self, data: dict) -> None:

elif data["type"] == "Metadata":
pass # metadata is too noisy
elif data["type"] == "UtteranceEnd":
Copy link
Member

@theomonnom theomonnom Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it being sent every time we finish speaking? If so, we should remove the previous dispatch of END_OF_SPEECH to avoid duplicate events, (only when end_of_utterance_ms is enabled)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants