Skip to content

Commit

Permalink
[controller] Do not throw exception on retrying empty push (#1545)
Browse files Browse the repository at this point in the history
If the empty push of system store fails, the current code retries another empty push. We should not throw exception to block the admin channel on such cases.
  • Loading branch information
majisourav99 authored Feb 19, 2025
1 parent b0babcf commit 658d775
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6357,9 +6357,10 @@ public void validateAndMaybeRetrySystemStoreAutoCreation(
getReplicationFactor(clusterName, systemStoreName));
int versionNumber = version.getNumber();
writeEndOfPush(clusterName, systemStoreName, versionNumber, true);
throw new VeniceException(
"System store: " + systemStoreName + " pushed failed. Issuing a new empty push to create version: "
+ versionNumber);
LOGGER.warn(
"System store: {} pushed failed. Issuing a new empty push to create version: {} ",
systemStoreName,
versionNumber);
} else {
throw new VeniceRetriableException(
"System store:" + systemStoreName + " push is still ongoing, will check it again. This is not an error.");
Expand Down

0 comments on commit 658d775

Please sign in to comment.