Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Unused Netty Code path as we are only using PipelineV2 #739

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cleanup Unused Netty Code path as we are only using PipelineV2 #739

wants to merge 1 commit into from

Conversation

nizarm
Copy link
Contributor

@nizarm nizarm commented Dec 3, 2021

Cleanup Technical debt by removing all the Netty code paths associated with Pipeline V2. Since PipelineV2 is globally enabled for all the services, removing this unused code will greatly improve the readability and manageability of R2 Netty Stack

bohhyang
bohhyang approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@bohhyang bohhyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also update the version in the changelog.md and gradle.properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bohhyang bohhyang bohhyang approved these changes

Assignees

@ssheng ssheng

@bbarkley bbarkley

@rickzx rickzx

@bohhyang bohhyang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nizarm @bohhyang @ssheng @bbarkley @rickzx