Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup #185

Draft
wants to merge 2 commits into
base: 2.0-li
Choose a base branch
from
Draft

Fixup #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1833a60
Fixup
tusharg1993 Jun 24, 2021
9a4988c
Fix java version
tusharg1993 Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-and-test-on-pr-events.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ jobs:
# bring in all history because the gradle versions plugin needs to "walk back" to the closest ancestor tag
fetch-depth: 0
- name: Set up JDK 1.8
uses: actions/setup-java@v1
uses: joschi/setup-jdk@v2
with:
java-version: 1.8
java-version: '8'
- name: Build with Gradle and run all unit tests
uses: eskatos/gradle-command-action@v1
with:
Expand Down
1 change: 1 addition & 0 deletions clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,7 @@ public class KafkaConsumer<K, V> implements Consumer<K, V> {
static final long DEFAULT_CLOSE_TIMEOUT_MS = 30 * 1000;

// Visible for testing
// Some useless comment
final Metrics metrics;

private final Logger log;
Expand Down